Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Tag. #444

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Implementation of Tag. #444

merged 2 commits into from
Jul 23, 2024

Conversation

wenchaozhang-123
Copy link
Contributor

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@wenchaozhang-123 wenchaozhang-123 marked this pull request as draft May 22, 2024 08:14
@wenchaozhang-123 wenchaozhang-123 force-pushed the tag branch 6 times, most recently from edec6b2 to a1f032f Compare May 28, 2024 09:44
@wenchaozhang-123 wenchaozhang-123 force-pushed the tag branch 2 times, most recently from c135358 to 04cfb4b Compare June 5, 2024 06:12
@wenchaozhang-123 wenchaozhang-123 marked this pull request as ready for review June 5, 2024 06:13
@wenchaozhang-123 wenchaozhang-123 marked this pull request as draft June 5, 2024 06:13
@wenchaozhang-123 wenchaozhang-123 force-pushed the tag branch 17 times, most recently from f8df796 to fb82ea3 Compare June 11, 2024 08:41
@wenchaozhang-123 wenchaozhang-123 marked this pull request as ready for review June 11, 2024 08:51
@wenchaozhang-123 wenchaozhang-123 force-pushed the tag branch 18 times, most recently from 24485e1 to a003fd1 Compare July 11, 2024 01:38
@wenchaozhang-123 wenchaozhang-123 force-pushed the tag branch 5 times, most recently from 89fb4d5 to 1e3ce93 Compare July 11, 2024 12:01
We implement tag in this commit. Tag can be attached to target database
object, which maybe database, user, schema, table etc. Tag has allowed
values, when we attach one tag to target object, we should specify this
tag's value which must be in allowed values array, otherwise will error
out.

To use it, we will illustrate some example as following:
CREATE TAG tag_example allowed_values '123', 'abc';
CREATE USER tag_user;
ALTER USER tag_user TAG (tag_example = '123');
ALTER TAG tag_example ADD ALLOWED_VALUES 'def';
ALTER TAG tag_example DROP ALLOWED_VALUES 'abc';

Authored-by: Zhang Wenchao zwcpostgres@gmail.com
As there are three ao/aocs tables in the prevent_ao_wal isolation2 test, the
expected results of wal are not stable after VACUUM. We fix this by truncate
unrelated table in lockmodes test.

Authored-by: Zhang Wenchao zwcpostgres@gmail.com
@my-ship-it my-ship-it merged commit d1103ed into apache:main Jul 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants